Reports for context, I'm considering sending these directly to the list since new reports a rather rare. Opinions?
New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1317354: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike_tokenizer.h: 237 in () _____________________________________________________________________ *** CID 1317354: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike_tokenizer.h: 237 in () 231 break; 232 } 233 { 234 char end = 0; 235 if( (data[pos] == '(' && (end=')')) || 236 (data[pos] == '[' && (end=']')) || >>> CID 1317354: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) >>> During compilation of file >>> '/home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike.c' 237 (data[pos] == '{' && (end='}')) ) 238 { 239 for (pos++; pos<len-1; pos++) 240 if (data[pos] == '#' && data[pos+1] == end) 241 { 242 pos++; ** CID 1317353: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike_tokenizer.h: 236 in () ___________________________________________________________________________ *** CID 1317353: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike_tokenizer.h: 236 in () 230 goto failed_to_find_end; 231 break; 232 } 233 { 234 char end = 0; 235 if( (data[pos] == '(' && (end=')')) || >>> CID 1317353: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) >>> During compilation of file >>> '/home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike.c' 236 (data[pos] == '[' && (end=']')) || 237 (data[pos] == '{' && (end='}')) ) 238 { 239 for (pos++; pos<len-1; pos++) 240 if (data[pos] == '#' && data[pos+1] == end) 241 { ** CID 1317352: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike_tokenizer.h: 235 in () _____________________________________________________________________________ *** CID 1317352: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike_tokenizer.h: 235 in () 229 if (pos >= len) 230 goto failed_to_find_end; 231 break; 232 } 233 { 234 char end = 0; >>> CID 1317352: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) >>> During compilation of file >>> '/home/covscan/pike/Pike-v8.0-snapshot/src/modules/Parser/pike.c' 235 if( (data[pos] == '(' && (end=')')) || 236 (data[pos] == '[' && (end=']')) || 237 (data[pos] == '{' && (end='}')) ) 238 { 239 for (pos++; pos<len-1; pos++) 240 if (data[pos] == '#' && data[pos+1] == end) _____________________________________________________________________________