Hi, I thought I'd try to tackle the markers / regions bug from the pitivi love page: https://bugzilla.gnome.org/show_bug.cgi?id=608682
I've made a little progress, and I'd like to get feedback as to the
direction I'm going, as well as with a couple of issues I'm having.
Basically the model I'm going for is the little ribbon bookmarks you
see in some fancified books. Click the ruler (or hit the 'm' key) to
put a mark on it.
Here's what I've got working:
o Click on the ruler, and a popup opens where you can enter text and
create a mark at the clicked time.
o Hover over a created mark, and a popup with the timestamp and label shows up.
o Click on a created mark, and you can edit it.
o <Escape> deletes the mark being edited, <Enter> saves it.
o Marks properly 'flow' with the ruler when zoomage happens.
o Marks get saved and loaded with the project.
I'd like to know:
o Does this seem like the right direction, and something that could
eventually be merge-able, or do I need to scrap this and go in a
different direction? (Or back to my day job ;-))
o Any feedback on the UI direction I'm taking?
o Any feedback on the code, specifically how I'm using pygtk - I've
barely ever used it before...
o What else should I get working to make this mergeable?
o Specific PyGTK question: For the 'MarkTips' window, if I instantiate
it as a gtk.WINDOW_POPUP, it doesn't seem to get key events (the
parent window does). Do I need to rig up the handler in the parent to
proxy events back to the child? I also noticed the
'set_transient_for' call, but I don't see an easy way to reference the
'grandparent' widget - ruler.parent.parent.parent.parent just doesn't
seem like a good idea for some reason. :-)
Specific things I know I want to fix:
o Colors.
o Mark Regions.
o The mark editing dialog thing.
o Keyboard shortcuts ('m' to create mark at the current point).
Thanks,
-RN
--
Robin Norwood
"The Sage does nothing, yet nothing remains undone."
-Lao Tzu, Te Tao Ching
01-pitivi-marks.patch
Description: Binary data
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev
_______________________________________________ Pitivi-pitivi mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi
