2010/3/1 Jeff <[email protected]>: > > > o Click on the ruler, and a popup opens where you can enter text and > create a mark at the clicked time. > > Hmmm. I'd recommend not doing that, because clicking (and click+dragging) on > the ruler is used to seek. I'd prefer if you used a keyboard shortcut + a > menu item (as suggested in the bug report). It also breaks other things (see > the end of this mail).
Oh, right. Ok. Once I figure out how to get the keybindings working, I'll remove the on-click handler. > o <Escape> deletes the mark being edited, <Enter> saves it. > > OK for "Enter = save", but "Escape = delete" is wrong. It is not an expected > keyboard binding. Escape should be used to "exit editing mode and discarding > the changes since the last time you entered the edit mode", not deletion. Yeah, this way is definitely wrong, but it made for easy testing while I developed it. I've been trying to decide if it needs buttons (I was thinking along the lines of small circular checkmark/redx). > Deletion should not have a keyboard shortcut (or maybe Ctrl+Delete, but not > simply "Delete" because that would prevent deleting characters with it). > > All the rest sounds good so far, in theory. Good work :) > > Other issues that I noticed when actually testing the patch: > - The markers are bright red, same color as the playhead. This should > definitely change. Yeah. Do you think having different colored marks (or 'mark groups') would be useful? Or should I just pick a non-red color for now? > - They look a bit clunky/unpolished: they are simply rectangles instead of > being pretty shapes (but I understand/presume it's not trivial to do) Yeah, they're actually just very thick lines. I'll have to look at polygons. I assume I can blit images onto the pixbuf, I'll need to experiment. What would your ideal look be? > - The marker labels could be shown at all times (in an ellipsized version), > not requiring to always hover them with the mouse to get a tooltip) Well, I wasn't sure how to deal with overlapping tips? ie, I zoom in all the way, create a few tips, then zoom all the way out, all of the tips I just made are on the far-right side of the ruler...how should it behave? > - Clips should be able to snap to them? That's an interesting idea. I'll keep it in mind. > - You currently can't move them/right-click them. Yup. > - Their position jumps around/breaks when you zoom in. Weird. I thought I had this working, but I see what you mean. I'll have to see if I can fix it. -RN -- Robin Norwood "The Sage does nothing, yet nothing remains undone." -Lao Tzu, Te Tao Ching ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Pitivi-pitivi mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pitivi-pitivi
