Seems reasonable. Though it might be confusing to label this "1.0" where it
requires Pivot 1.1. Perhaps 1.1 would be better.
On Thursday, April 02, 2009, at 02:54AM, "Christopher Brind"
<[email protected]> wrote:
>Since the JFreeChart implementation is separate to the main release, I think
>it should have a version number in its name. e.g.
>http://pivot.googlecode.com/files/pivot-charts.jfree_1.0.jar
>
>...just in case the charts code changes and that implementation then becomes
>incompatible.
>
>(I'll download the sanity check release stuff and try it from work in about
>an hour)
>
>Cheers,
>Chris
>
>
>
>
>2009/4/2 Niclas Hedhman <[email protected]>
>
>> On Thu, Apr 2, 2009 at 11:32 AM, Todd Volkert <[email protected]> wrote:
>> >> But it looks like the Javadocs has not been fixed yet and still
>> >> containing the skin.
>> >>
>> >> doc/pivot/charts/skin/XYSeriesDataset.html:<DT><B>Specified
>> >> by:</B><DD><CODE>getDomainOrder</CODE> in interface
>> >> <CODE>org.jfree.data.xy.XYDataset</CODE></DL>
>> >
>> > Ah, good catch -- I'll fix tomorrow morning. Thanks.
>> >
>>
>> And in README I find the following passage;
>>
>> "* Pivot's charting components require a compatible chart provider. An
>> implementation based on JFreeChart is available here:
>>
>> http://pivot.googlecode.com/files/pivot-charts.jfree.jar
>>
>> This provider requires JFreeChart 1.0.9 and JCommon 1.0.12, available from
>> http://www.jfree.org. Later releases may also work, but have not been
>> tested.
>> "
>>
>> I would recommend a change of wording here.
>>
>> "If you intended to use the charting components of Pivot, then you
>> will need a compatible chart provider. No such provider is included in
>> this release, but one is available here;"
>> "Please notice that this component has a dependency on JFreeChart that
>> is licensed under LGPL."
>>
>> Or something to that extent.
>>
>> Cheers
>> --
>> Niclas Hedhman, Software Developer
>> http://www.qi4j.org - New Energy for Java
>>
>> I live here; http://tinyurl.com/2qq9er
>> I work here; http://tinyurl.com/2ymelc
>> I relax here; http://tinyurl.com/2cgsug
>>
>