Hi, sorry but I need some answers, I'd like to complete this work for
this end of the week (for the 1.3 release), at least for have a dark
color scheme. See previous mails ...
Update:
> If possible, I'd commit this line but commented (with a comment on
> what it means), to simplify tests and to show others how to do this
> ... until I'll have time (for 1.3.x) to create such demo, ok ?
I have an idea of a simple Demo (or better, a test), for the 1.3.1 ,
like DarkColorsTest:
using my customized json file, and with a rollup with:
1 panel (rollup here expanded but disabled, to do some visual tests)
with some header info,
1 panel (rollup here expanded) with inside a form like search fields,
1 panel with a table inside
> Ah, I'm satisfied of my dark test json file, can I commit (overwriting
> the original) ?
The original file is not referenced anywhere, so i think it's safe for
me to overwrite.
>>> Point 2:
>> Todd is probably best suited to comment here.
> Ok, I'll wait Todd answers ...
What do you say ?
>>> Point 3:
>>> for better consistency with similar elements, I've changed the default
>>> color used for Rollups, this is the patch, should I apply ?
>>
>> I think that looks too dark. The current color was actually chosen by a
>> graphic designer - I think we should leave it as-is.
> For consistency, I used the same default as Labels and other components.
> In the current implementation (color) I think there is only little
> contrast with default background of panels, so for me it hasn't much
> visibility, and in the case of disabled rollup, the disabled color
> could be too similar.
I've just seen that for example in Vista and OS X, trees have an
element like this, and the default color is like my proposal ... so
commit ?
>>> Point 4:
> But in any case, what do you think on changing default colors for
> these components (described in my previous mail), to align on colors
> already used with other components ?
>
Comments ?
Ah, for the release, I've seen there is a new version of Groovy, can i
update the jar (inside demos if i remember well), if the related demo
works, or there are other tests to do on this ?
A little thing, that could go in 1.3.1:
for the Skin, I've seen that in TerraTheme, are defined
private Font font = null;
private Color[] colors = null;
but what do you think on moving them to the base class ?
And also for other checks, like that the color index will be in the
right range, I'm thinking to add a method like
getNumberOfPaletteColors() , and also this could go in the base class.
What do you think ?
Thanks a lot,
Sandro
