Hi Todd, > I'd create a new file just to preserve the original's attempt (albeit > amateur - I made it) at another color scheme. Ok, so at this point I'll put my json colors in a new file, shipped with my DarkColorsTest, I hope in the 1.3.1 .
Idea: I'll send a mail to pivot users to ask them if they have done something like this, posting my sample, and see what happen, ok ? > TerraPushButtonSkin defines the bevel color as as > TerraTheme.brighten(backgroundColor) and the pressed bevel color as > TerraTheme.darken(backgroundColor). So if your background color is, say, > black, then the darker version of black is still black, so the button will > look the same when it's pressed. #0a0a0a is close enough to black that my > guess is that this is what is happening in your case. I've taken my point of view, and i agree with this. > And for this, if i could have in the json file also an optional >> multiplier (coefficient: 0.0 .. 1.0) for telling how much darken and >> how much brighten ... wdyt (what do you think) ? >> > > Not a bad idea - can you create a JIRA ticket for it, probably marked > against 1.4. Great, I'll add a ticket, maybe for the 1.3.x . > TreeView uses a darker color for its expand/collapse control. I agree that > since the existing color in Rollup was chosen a graphic designer, we should > leave it. Ok, i don't like this choice (i thing it has poor contrast / visibility with default backgrounds), but i can live with it ... > Again, all these colors were chosen by a graphic designer that designed the > terra theme - I think we had better not muck with them without the aid of a > graphic designer. In general, that'll be part of a larger exercise to Ok, i don't like this "all these colors were chosen by a graphic designer" (so we can't think to change/improve it ?), but i can live with it ... > design a new theme that replaces terra (see > http://issues.apache.org/jira/browse/PIVOT-29). Ok, but the 2.0 in far ... But my complaints was to fix some (mistakes ?) in color choosing in some components, like this: > the TerraTextInputSkin (used colors 11 and 10 instead of the base color 10 > and its variant 9) ... > but in this case re-running my kitchen sink i see no changes (is it > overridden in some place ? I've not seen where ... can you help me, please). > AlertSkin uses 9 instead of the base color 10 used in other components for > background (or 4). > Sheet uses background 11 (with custom alpha) instead of 10. > And probably others ... suggestions ? In this case, it's not from a graphic point of view (color changes here are little), but for better consistency with other components. > Might as well give it a shot. We'd have to update > PIVOT-139<https://issues.apache.org/jira/browse/PIVOT-139>to say > Groovy 1.7 :) I'd like to update to the current Groovy version, so we'll have our 1.3 aligned to the best version of related tool. For the 1.7 I'd wait the final release. > I disagree - a different theme might not even use a palette, or use a > palette that's conceived of differently (not indexed for instance). And it > might have a set of fonts or a font family... let's not put any artificial > restrictions on what a theme must have. Ok, I understand. Bye
