Hi to all,
i think to have just finished to add missing @Override in pivot
sources (i hope :-) ).
I've seen some small things:
- in TerraTreeViewSkin, there are a warning on two empty for, in
addVisibleNode() and in removeVisibleNodes() ... as seen before for
other warnings on while empty I think should be modified, for better
readability, and to avoid warnings ...
- in TerraTableViewHeaderSkin, i got this warning "Exporting
non-public type through public API"
protected SortIndicatorImage sortAscendingImage = new
SortIndicatorImage(SortDirection.ASCENDING);
protected SortIndicatorImage sortDescendingImage = new
SortIndicatorImage(SortDirection.DESCENDING);
changing them to private solve ... i make the change, right ?
- there are many warnings on "Local variable hides a field" (in many
sources), and i know the the code works good also with this, but what
do you think on changing a little these variables, to avoid this ?
Using Best practices always help ...
Tell me.
Sandro
