> Thanks! Can you resolve the JIRA ticket?
Ok, fixed.
> In those cases, there are comments right before the loops explaining what's
> going on, and they're just scanning loops (used to position an int
> variable). Can you suggest a different phrasing so we can see the options?
Very simple ... instead of the ";", use an empty { } ... ok, minimal
but at least the warnings are gone.
Ok ?
> I'd make the SortIndicatorImage class protected instead.
private (they are already protected) ...
> I actually think it's ok to have local variables hide a field. Otherwise,
> you end up naming your local variables with contrived names, and in most (if
> not all) cases where we do this, our local variable is a view (or decorator,
> in design pattern terminology) of our field, so the naming parity is
> intentional.
Ok, but in this case we couldn't have the support of compiler and
tools, to check that the code inside is right ...
Usually I use a different variable name, maybe with only a little
difference in name, and but for me it's Ok the same.
Bye
