Ok, committed.

Now only another thing could be interesting to fix:

DesktopApplicationContext.java:308 Incorrect lazy initialization and
update of static field
org.apache.pivot.wtk.DesktopApplicationContext.applicationContext

Description:

This method contains an unsynchronized lazy initialization of a static
field. After the field is set, the object stored into that location is
further updated or accessed. The setting of the field is visible to
other threads as soon as it is set. If the futher accesses in the
method that set the field serve to initialize the object, then you
have a very serious multithreading bug, unless something else prevents
any other thread from accessing the stored object until it is fully
initialized.

Even if you feel confident that the method is never called by multiple
threads, it might be better to not set the static field until the
value you are setting it to is fully populated/initialized.


What do you think, is it safe to ignore ?

Bye

Reply via email to