On 2015-03-27 17:45:04 [+0100], Andreas Cadhalpun wrote: > Hi Sebastian, Hi Andreas,
> On 26.03.2015 22:09, Sebastian Andrzej Siewior wrote: > > I added a symbol file to linking. I removed the "combo" symbols from beeing > > exported since it is enough to use them internally. I pushed this to > > upstream > > and I am waiting for response. But since those functions are the unrolled > > versions of the "base" function I don't see any reason to export them. > > Yes, it's probably best to hide these implementation details from the API/ABI. > But then the function declarations should be moved from the installed tfm.h > header to a private one, e.g. tfm_private.h. Hmm. Right. I will check with upstream what he thinks would be best practise here. > There are some more functions in the section 'VARIOUS LOW LEVEL STUFFS', > which could also be made private (s_fp_add, s_fp_sub, fp_reverse). goodie. I droped them and also fp_s_rmap. > Best regards, > Andreas Sebastian _______________________________________________ Pkg-clamav-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-clamav-devel
