On December 17, 2015 5:43:21 PM EST, Sebastian Andrzej Siewior <[email protected]> wrote: >On 2015-11-23 17:06:35 [-0500], Scott Kitterman wrote: >> I finally had time to look at tomsfastmath again. A couple of >points: >> >> 1. patches/tfm-make-a-few-functions-static.patch changes the ABI, >doesn't it? > >Slightly, yes. Adding a const to function isn't that bad like removing >it. > >> Did upstream agree to do this, but just haven't released it yet or is >this >> still an open question for upstream? > >I'm not sure *how* this happened but I somehow overseen it and never >submitted it with my patch queue which ended up in the 0.13 release. >However upstream approved this change and it has been just pushed into >the repository: > https://github.com/libtom/tomsfastmath/commits/master >I however don't know when there will a new release and I doubt it makes >sense to make one just with this change.
As long as they've agreed so we don't have a long term Debian unique ABI, I think it's fine. >> 2. Public domain is problematic in many jurisdictions, Germany and >the United >> States being two. That's why he's got WFPL in the LICENSE file as >well. >> Please include that in debian/copyright and then adjust the package >> description (may just say 'very liberally licensed' if you feel >that's an >> important point). > >Oh, that license has been in the 0.13 release, too. I added that part >about WTFPL in the copyright and kept "public domain" as copyright >"holder". Hope that is okay. I removed that "public domain" part from >the package description. I don't think that the license is that >important here. OK. >> Other than that, I'd upload it now. > >What about now. You feel like uploading it now? :) Maybe next week, but you can just do it yourself too. Scott K _______________________________________________ Pkg-clamav-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-clamav-devel
