Hi,

martin f krafft wrote, Wednesday, April 09, 2008 3:00 PM


When I run debcommit -a in a git repo, I get e.g.

ignore.d.workstation/kernel
* ignore.d.workstation/kernel
- also ignore loading of R300 microcode (closes: #474606).

Are you being presented with an editor at this point?

There are two problems with this. First, the first line makes no
sense and I don't know how devscripts gets it.

Assuming you were being presented with an editor, this is due to the changes requested in #402531 ("format commit messages better for git"). The first full change is unfolded for use as a template summary line and prepended to the full list of changes. An editor is then spawned so that you can edit the summary as desired. This is documented :-)

There's intended to be a blank line between the summary and body; I'll have a look at why that's getting lost in this case.

And second, the indent of the third line (two spaces) is lost.

That looks like a side-effect of a request I received (outside the BTS) to enhance the "strip message" functionality so that if the leading "* " was stripped to also strip the leading spaces from subsequent lines as removing the "* " meant the following lines were no longer intended correctly. For some reason the "* " isn't being correctly stripped in this case, however.

Ah. I have a suspicion as to what might be causing this. The code which decides whether more than one change is present in order to spawn the editor treats a change as any line beginning with *, - or + so that "subchanges" aren't included in the summary line. The "strip message" code however still only considers lines beginning with *; the two should be unified so that your example is treated as two changes and left intact.

Regards,

Adam





--
To unsubscribe, send mail to [EMAIL PROTECTED]

Reply via email to