Author: adam-guest
Date: 2008-10-12 15:41:29 +0000 (Sun, 12 Oct 2008)
New Revision: 1662

Modified:
   trunk/debian/changelog
   trunk/scripts/checkbashisms.pl
Log:
* checkbashisms:
  + Recognise the use of "source" with quoted arguments. (Closes: #501171)

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2008-10-12 15:37:36 UTC (rev 1661)
+++ trunk/debian/changelog      2008-10-12 15:41:29 UTC (rev 1662)
@@ -8,9 +8,10 @@
     + Expand on the definition of "claim" in the manpage. (Closes: #501142)
     + Trim anything that doesn't look like an e-mail address from $DEBEMAIL or
       $EMAIL before using it for un/claim or un/subscribe. (Closes: #501162)
-  * checkbashisms: Recognise brace expansions containing a leading or
-    trailing empty value ("{,foo}", etc). Thanks Jonny Lamb.
-    (Closes: #499971)
+  * checkbashisms:
+    + Recognise brace expansions containing a leading or trailing empty value
+      ("{,foo}", etc). Thanks Jonny Lamb. (Closes: #499971)
+    + Recognise the use of "source" with quoted arguments. (Closes: #501171)
   * debdiff: Ensure exit status is always explicitly set (and set
     correctly). (Closes: #500256)
   * debian/rules: Create a link from the French pts-subscribe manpage

Modified: trunk/scripts/checkbashisms.pl
===================================================================
--- trunk/scripts/checkbashisms.pl      2008-10-12 15:37:36 UTC (rev 1661)
+++ trunk/scripts/checkbashisms.pl      2008-10-12 15:41:29 UTC (rev 1662)
@@ -445,8 +445,6 @@
     %bashisms = (
        qr'(?:^|\s+)function \w+(\s|\(|\Z)' => q<'function' is useless>,
        $LEADIN . qr'select\s+\w+' =>     q<'select' is not POSIX>,
-       $LEADIN . qr'source\s+(?:\.\/|\/|\$)[^\s]+' =>
-                                      q<should be '.', not 'source'>,
        qr'(test|-o|-a)\s*[^\s]+\s+==\s' =>
                                       q<should be 'b = a'>,
        qr'\[\s+[^\]]+\s+==\s' =>        q<should be 'b = a'>,
@@ -524,6 +522,8 @@
     %singlequote_bashisms = (
        $LEADIN . qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[\\abcEfnrtv0])+.*?[\']' 
=> q<unsafe echo with backslash>,
        #'(?<![\$\\\])\$\'[^\']+\''              => q<$'...' should be 
"$(printf '...')">,
+       $LEADIN . qr'source\s+[\"\']?(?:\.\/|\/|\$)[^\s]+' =>
+                                      q<should be '.', not 'source'>,
     );
 
     if ($opt_echo) {



-- 
To unsubscribe, send mail to [EMAIL PROTECTED]

Reply via email to