Your message dated Sun, 11 Jan 2009 17:47:06 +0000
with message-id <[email protected]>
and subject line Bug#507482: fixed in devscripts 2.10.35lenny2
has caused the Debian Bug report #507482,
regarding [debsign] Insecure tmpdir creation
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
507482: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507482
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.41
Severity: normal
Tags: security


        Hi

 I don't know how exploitable tmp dirs with debsign's files are,
 probably not much, but this could be avoided:

dosigning() {
    # Do we have to download the changes file?
    if [ -n "$remotehost" ]
    then
        cd ${TMPDIR:-/tmp}
        if [ ! -d "debsign.$$" ]
        then
            mkdir debsign.$$ || { echo "$PROGNAME: Can't mkdir!" >&2; exit 1; }
        fi
        trap "cleanup_tmpdir" 0 1 2 3 7 10 13 15
        cd debsign.$$


 Please don't use $$, also I think it'd be best to setup the clean hook
 before creating the dir.

 Something like:

tmp_dir=""
cleanup() {
    if [ -n "$tmp_dir" ]; then
        rm -rf "$tmp_dir"
    fi
}
trap "cleanup" 0 1 2 3 9 11 13 15
tmp_dir="$(mktemp -dt "debsign.XXXXXXXXXX")"

  Cheers

-- 
Loïc Minier



--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.10.35lenny2

We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:

devscripts_2.10.35lenny2.dsc
  to pool/main/d/devscripts/devscripts_2.10.35lenny2.dsc
devscripts_2.10.35lenny2.tar.gz
  to pool/main/d/devscripts/devscripts_2.10.35lenny2.tar.gz
devscripts_2.10.35lenny2_amd64.deb
  to pool/main/d/devscripts/devscripts_2.10.35lenny2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam D. Barratt <[email protected]> (supplier of updated devscripts 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 10 Jan 2009 18:07:35 +0000
Source: devscripts
Binary: devscripts
Architecture: source amd64
Version: 2.10.35lenny2
Distribution: testing
Urgency: low
Maintainer: Devscripts Devel Team <[email protected]>
Changed-By: Adam D. Barratt <[email protected]>
Description: 
 devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 507482
Changes: 
 devscripts (2.10.35lenny2) testing; urgency=low
 .
   * debsign: Use mktemp rather than a directory based on the process ID.
     (Closes: #507482)
Checksums-Sha1: 
 3f773d5869204848f954b63000c05382c8fbb156 1417 devscripts_2.10.35lenny2.dsc
 8923d36ef0f83e47912ca628ccbfa9aec7449706 599571 devscripts_2.10.35lenny2.tar.gz
 3a4e5befa7daa932eb9c43fffba422407d78efe1 516738 
devscripts_2.10.35lenny2_amd64.deb
Checksums-Sha256: 
 bf19129732e81e8d85300b07707af6426569c6e3206b55446388183dff5e2dc5 1417 
devscripts_2.10.35lenny2.dsc
 711903edbdd26cb88a96baa2f7ceafdefb9ca900634f708693348c7ff15ef855 599571 
devscripts_2.10.35lenny2.tar.gz
 c673c65104d5124f31525981b2f01dd1c7c50058af1cc92f48628e15ab687ea1 516738 
devscripts_2.10.35lenny2_amd64.deb
Files: 
 f0f4703fa6d6b616217b46f638c8aa02 1417 devel optional 
devscripts_2.10.35lenny2.dsc
 be11a56d4dd50f46424c9642defa2ca4 599571 devel optional 
devscripts_2.10.35lenny2.tar.gz
 64cf185b3d0dc1a3d2ac1bf7294f2811 516738 devel optional 
devscripts_2.10.35lenny2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklqLxsACgkQokcE1TReOoWtaACffEVXxvfSw4jtqnZug2RbhBy1
J6wAnjc6DHGRwLIb1p/MDlKGTHdzsob4
=Ubut
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to