Your message dated Sat, 17 Jan 2009 01:52:26 +0000
with message-id <[email protected]>
and subject line Bug#507482: fixed in devscripts 2.9.26etch2
has caused the Debian Bug report #507482,
regarding [debsign] Insecure tmpdir creation
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
507482: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507482
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.41
Severity: normal
Tags: security


        Hi

 I don't know how exploitable tmp dirs with debsign's files are,
 probably not much, but this could be avoided:

dosigning() {
    # Do we have to download the changes file?
    if [ -n "$remotehost" ]
    then
        cd ${TMPDIR:-/tmp}
        if [ ! -d "debsign.$$" ]
        then
            mkdir debsign.$$ || { echo "$PROGNAME: Can't mkdir!" >&2; exit 1; }
        fi
        trap "cleanup_tmpdir" 0 1 2 3 7 10 13 15
        cd debsign.$$


 Please don't use $$, also I think it'd be best to setup the clean hook
 before creating the dir.

 Something like:

tmp_dir=""
cleanup() {
    if [ -n "$tmp_dir" ]; then
        rm -rf "$tmp_dir"
    fi
}
trap "cleanup" 0 1 2 3 9 11 13 15
tmp_dir="$(mktemp -dt "debsign.XXXXXXXXXX")"

  Cheers

-- 
Loïc Minier



--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.9.26etch2

We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:

devscripts_2.9.26etch2.dsc
  to pool/main/d/devscripts/devscripts_2.9.26etch2.dsc
devscripts_2.9.26etch2.tar.gz
  to pool/main/d/devscripts/devscripts_2.9.26etch2.tar.gz
devscripts_2.9.26etch2_amd64.deb
  to pool/main/d/devscripts/devscripts_2.9.26etch2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adam D. Barratt <[email protected]> (supplier of updated devscripts 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 10 Jan 2009 17:41:14 +0000
Source: devscripts
Binary: devscripts
Architecture: source amd64
Version: 2.9.26etch2
Distribution: stable
Urgency: low
Maintainer: Julian Gilbey <[email protected]>
Changed-By: Adam D. Barratt <[email protected]>
Description: 
 devscripts - Scripts to make the life of a Debian Package maintainer easier
Closes: 507482
Changes: 
 devscripts (2.9.26etch2) stable; urgency=low
 .
   * debsign: Use mktemp rather than creating a temporary directory named
     after the process ID. (Closes: #507482)
Files: 
 14880a5a638be807591f785a05425767 682 devel optional devscripts_2.9.26etch2.dsc
 092c3d532bf47264b622b7dc6adc4756 437180 devel optional 
devscripts_2.9.26etch2.tar.gz
 4f14db5aa4479e94915d12d188f67e6c 393618 devel optional 
devscripts_2.9.26etch2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAklo3zQACgkQokcE1TReOoXE7ACgnvVMKvKCdcrZOF/l3cX0rmem
o9sAnAwJpC5HX2J6PT88LIlPnLpMFtHA
=HGrb
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to