On Thu, Jan 17, 2008 at 04:40:54PM -0800, Dan Price wrote:
> http://cr.opensolaris.org/~dp/ips-status/
Pretty much just a bunch of nits ...
You're using tabs instead of spaces for indentation in many places. If
it's not going to be too much, could you expand your tabs to eight spaces?
client.py:
- line 338: you pass progress as a named argument, while it's not defined
that way. Perhaps it could be an optional argument, but if you don't
want to do that, then just put the args in order.
generic.py:
- line 275: you need a docstring for this method.
- line 277: does "str(self)" not work?
pkgplan.py:
- line 259: no need for the backslash when the newline is enclosed in
parens (or brackets). There may be other instances of this, but I only
just noticed this one.
progress.py:
- line 39: Yes, PLEASEDO. :)
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
