On Fri 18 Jan 2008 at 03:40PM, Danek Duvall wrote:
> On Thu, Jan 17, 2008 at 04:40:54PM -0800, Dan Price wrote:
>
> > http://cr.opensolaris.org/~dp/ips-status/
>
> Pretty much just a bunch of nits ...
>
> You're using tabs instead of spaces for indentation in many places. If
> it's not going to be too much, could you expand your tabs to eight spaces?
(I'm not the only one committing this sin.) I cleaned it up in all the
files I have touched.
I'll try to adapt but after 9 years working in ON I have to say that
tabs, not spaces, are just what I expect these days.
> client.py:
>
> - line 338: you pass progress as a named argument, while it's not defined
> that way. Perhaps it could be an optional argument, but if you don't
> want to do that, then just put the args in order.
Ok, fixed.
> generic.py:
>
> - line 275: you need a docstring for this method.
>
> - line 277: does "str(self)" not work?
Thanks, fixed.
> pkgplan.py:
>
> - line 259: no need for the backslash when the newline is enclosed in
> parens (or brackets). There may be other instances of this, but I only
> just noticed this one.
Ok, fixed.
> progress.py:
>
> - line 39: Yes, PLEASEDO. :)
Yeah, I added a whole raft of comments.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
