Looks correct to me Danek?Just a thought - with one or two-line code reviews on my team, we let the team members self-review. It saves time, which is sometimes quite precious for us, and the risk is minimal because it only applies to small, tested changes.
I'm not suggesting that all contributors to the IPS project get to self-review, but maybe for the core contributors this would be okay?
Trev Danek Duvall wrote:
Here's a quick one to get rid of one of the testsuite failures. My bad.
http://cr.opensolaris.org/~dduvall/pkg-884/
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
