Dan Price wrote:
On Fri 28 Mar 2008 at 08:42AM, Trevor Watson wrote:Looks correct to me Danek?Just a thought - with one or two-line code reviews on my team, we let the team members self-review. It saves time, which is sometimes quite precious for us, and the risk is minimal because it only applies to small, tested changes.I'm not suggesting that all contributors to the IPS project get to self-review, but maybe for the core contributors this would be okay?-1, personally, to "one or two line changes". You can do a lot of damage with one line of python.
Agreed - I have ;)
If you want to come up with an alternative definition, like "minor test suite changes" then I'm in favor: I made a similar proposal which was tabled until someone (me?) makes further improvements to the test suite.
Maybe that's a suitable definition then, which limits risk.
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
