Tom,
> Tim, > A few questions/comments: > > 1. How will this work for user images being manipulated by non-root users? > It won't since only root can manage Boot Environments. I'll have to add an uid check and skip the recovery stuff for user images. > 2. How does this feature work when the root filesystem is not ZFS? > There is a check for that "if not self.get_env():" and if the statement is true then all recovery stuff will be bypassed. > 3. Do you have ideas on how to make this portable to older Solaris > releases and non-Solaris environments (Linux, Windows, etc.)? I'm It is all based on the supported namespace <pool>/ROOT/<beName> existing and it being a zfs dataset. So if either of those don't exist then no recovery will happen. > assuming that in that case the import of the bootenv module would fail. It should be able to be imported on any platform if bootenv.py exists. bootenv will quietly ignore any file system not of the aforementioned type. > Can the client.py deal with this condition gracefully? Maybe this would Yes it should be able to as mentioned above. > also deal with questions 1 and 2. > > 4. The import of beadm.libbe_glue at line 27 of client.py appears to be > unused. > Yep. I removed it. Thanks Tim > Thanks. > Tom > > Tim Knitter wrote: >> All, >> >> Can I get a review of the following: >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=863 >> >> http://cr.opensolaris.org/~tsk/863 >> >> Note that with this change, once integrated, pkg(1) will depend on >> SUNWinstall-libs. So in order to build a clone of >> hg.opensolaris.org/hg/pkg/gate one must install the SUNWinstall-libs >> package first. Or one could clone >> hg.opensolaris.org/hg/caiman/snap_upgrade build it and install >> SUNWinstall-libs from $ROOT/package after building. >> >> Thanks >> Tim >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
