Danek Duvall wrote: > On Fri, Mar 28, 2008 at 11:53:36AM -0600, Tim Knitter wrote: > >>>> It won't since only root can manage Boot Environments. I'll have to >>>> add an uid check and skip the recovery stuff for user images. >>> If I might interject, why a uid check? >> EOU. > > Not really. UID checks are awful in this day and age. I'd hazard that > permission checks of any type are probably not the best in the world. > Authorization checks are fine, but a check to guess whether something will > succeed or not is going to need to be rewritten at some point in the > future; best to get it right now. > >> Well if we went that route currently libbe would spit out a permission >> denied message for the following operation: >> >> line1-x2100% pkg -R /export/home/utest install [EMAIL PROTECTED] >> be_create_snapshot: recursive snapshot of >> rpool/ROOT/[EMAIL PROTECTED]::2008-03-28-16:29:03 failed: permission denied >> pkg: unable to create auto snapshot. >> >> Which is ok however in this case it would probably produce a lot of >> support noise and confusion since the recovery feature is secondary to >> the success/failure of the pkg operation. > > You can control what gets printed by the software you write, right? So
Sure. However some messages, this in particular, come from libbe which needs to finish implementing its proposed return codes so messaging is better controlled. > just don't print the error, and drive on. Or warn with something more > user-friendly -- "solution-oriented error message" would be the appropriate > buzzword, I think. Right. I added "pkg recovery is disabled" until libbe returns an error code for invalid permissions. Tim > > Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
