> Can I get a review of the following: > > http://cr.opensolaris.org/~tsk/863
I took a look at this set of changes, and the libbe stuff. If we put this set of changes to a vote today, I would have to vote against this in its current state. As far as I can tell, this doesn't have any support for UFS, and doesn't have any check to disable the snapshot code if we're not on a ZFS filesystem. I did see some bit of code that calls os.system for zfs list in a constructor. However, given how much work has already been done to leverage libzfs, it seems like that check out to be done through the existing libraries and not by forking a process every time we create an object. I'd also like to see some additions to the test suite that test this for UFS and ZFS in both the successful and failure cases. Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
