[EMAIL PROTECTED] wrote:
>> Can I get a review of the following:
>>
>> http://cr.opensolaris.org/~tsk/863
>
> I took a look at this set of changes, and the libbe stuff.
>
Thanks for reviewing it.
> If we put this set of changes to a vote today, I would have to vote
> against this in its current state.
>
> As far as I can tell, this doesn't have any support for UFS, and doesn't
> have any check to disable the snapshot code if we're not on a ZFS
> filesystem.
Actually none of the recovery stuff will happen on ufs. There is an explicit
check against the -R argument or / if we operating on a live system. If the
following check in bootenv.py is true we are guaranteed to be operating on a
zfs FS whose -R argument or / is a dataset managed by libbe.
if self.beList[idx].get(be_mountpoint) == root:
This line means that libbe:be_list() succeeded and that the -R argument pkg(1)
is operating on is managed by libbe.
If we are operating on UFS the above check will never be true. I tested this by
creating a UFS file system, created directories that looked like
rpool/ROOT/beName and ran pkg(1).
>
> I did see some bit of code that calls os.system for zfs list in a
> constructor. However, given how much work has already been done to
I took that check out since it was unneeded and the above fully qualifies the
system as a target for recovery.
> leverage libzfs, it seems like that check out to be done through the
> existing libraries and not by forking a process every time we create an
> object.
Agreed. It's been nuked.
>
> I'd also like to see some additions to the test suite that test this for
> UFS and ZFS in both the successful and failure cases.
>
Will do. Should be able to add them this weekend. In the meantime I updated the
webrev, please have a gander. I also took out the hard requirement on
libbe_glue since pkg(1) is scoped for a wider range of OS's and snap is not.
libbe_glue is only imported if it exists. If it doesn't, recovery is silently
disabled.
http://cr.opensolaris.org/~tsk/863/
Thanks
Tim
> Thanks,
>
> -j
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
