Thanks for the review, Stephen.
> fmri.py:
>
> 154,
> 167,
> 181. Please use one of "not self.authority" or "self.authority ==
> None" (or equivalent).
Ok. I went with "if not authority"
> image.py:
>
> 359. Expand this comment, so we understand that the local copy of the
> manifest may not have had this information if the last
> installation of the package was with an older version of the
> client.
How's this?
# Write the originating authority into the manifest.
# Manifests prior to this change won't contain this information.
# In that case, the client attempts to re-download the manifest
# from the depot.
> 833. Need to explain the preferred/non-preferred matching in a
> docstring.
Added this docstring:
"""Take a list of packages, specified in pkg_list, and attempt
to install them on the system.
This method checks all authorities for a package match;
however, it defaults to choosing the preferred authority
when an ambiguous package name is specified. If the user
wishes to install a package from a non-preferred authority,
the full FMRI that contains an authority should be used
to name the package."""
> 980 - 987. I think that if we had zero matches in pnames, then we
> would want to check the non-preferred matches, but not if we had
> one match.
Do you mean?
elif len(npnames.keys()) > 1 and len(pnames.keys()) < 1:
<print error>
If so, then yeah, I agree this makes more sense than the existing
approach.
> manifest.py:
>
> 103. Shouldn't this be "set name=fmri value=%s\n"?
Good question. I was getting a traceback with the code in it's previous
state; however, when I put in the proper spacing, everything worked.
The actions/attribute.py module can handle either format, but if you'd
like these to be consistent, I'll change it.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
