On Wed, Mar 26, 2008 at 6:04 PM,  <[EMAIL PROTECTED]> wrote:
> In the current code, you can run into a fair amount of trouble if you
>  install a set of packages and then change the preferred authority.  The
>  preferred authority specifies the location from where packages are
>  obtained when the user doesn't explicitly declare an authority in the
>  FMRI.
>
>  This wad should eliminate the most common problems that occur if you
>  install from one repository, and then re-configure the client
>  to install from a different preferred authority.
>
>  Webrev is here:
>
>         http://cr.opensolaris.org/~johansen/pkg_auth2/

image.py
=====

      544 +                # then return the catalog for the preferred authority

Nit: missing period at end of sentence.

 611  721                  """Determine whether fmri and pfmri share
the same package
 623  733                  # If the catalog has a rename record that
names fmri as a

Nit: shouldn't those be cfmri instead of fmri?

I didn't see any new api tests for the new functions. Intentional?

imageconfig.py
=========
Please update the copyright year.

imageplan.py
========
Please update the copyright year.

fmri.py
====
Please update the copyright year.

I didn't see any new api tests for the new functions. Intentional?

Overall
====
I'm happy with this overall, great to see this!

Cheers,
-- 
Shawn Walker, Software and Systems Analyst
http://binarycrusader.blogspot.com/

"To err is human -- and to blame it on a computer is even more so." -
Robert Orben
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to