Danek Duvall wrote:
> On Fri, Apr 04, 2008 at 10:42:48PM -0600, Tim Knitter wrote:
>
>> It needs one more check after the initial gauntlet.                        
>> if beVals.get("mountpoint") != root:
>>         continue
>
> Okay, good to know I'm not crazy.

Well it was sure driving me crazy for a while since a pkg -R <bad_directory> 
reverted to updating '/'. I think this should be fixed. If the -R <arg> 
directory doesn't exist then I think pkg should halt instead of modifying '/'.

Anyway, I verified that the code in the webrev below works for all cases:

 image-update/install/uninstall {'/' | -R {<bad dir> | <good dir>}}

I also performed negative tests that also worked for the above cases.

If there aren't anymore comments I think it is good to go.

http://cr.opensolaris.org/~tsk/863.5/

Thanks
Tim

>
>> The BE has to be mounted before attempting to do an image update. If a BE 
>> isn't mounted then an image won't be available anyway, right? So unless we 
>> added a CLI change for image-update/install/uninstall to handle BE's then 
>> the user will always be on there own in mounting the BE first. I thought 
>> that adding a CLI change could come next release if we wanted to go that 
>> route.
>
> Okay, sounds good.
>
> Danek


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to