I fixed them all.

http://cr.opensolaris.org/~tsk/863.6/

Thanks Danek

Tim

Danek Duvall wrote:
> On Sat, Apr 05, 2008 at 01:09:48PM -0600, Tim Knitter wrote:
> 
>> http://cr.opensolaris.org/~tsk/863.5/
> 
> Mostly nits now.
> 
> client.py:
> 
>   - line 349: This "e" is actually used.
> 
> bootenv.py:
> 
>   - line 73: "expects"
> 
>   - line 95: nine-space indent
> 
>   - line 125: make this an else clause on the for loop.  It'll only be
>     invoked when the loop exits normally; i.e., without "break"ing out.
> 
>   - line 169, et al: no need for continuation backslash inside parens.
> 
> Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to