On Tue, Apr 8, 2008 at 3:40 PM, <[EMAIL PROTECTED]> wrote: > We need rudimentary SSL support in the pkg client for our upcoming > release. This set of changes adds basic SSL support to the client and fixes > a bunch of other bugs I created in my last few putbacks. > > Webrev is available here: > > http://cr.opensolaris.org/~johansen/pkg-sslcli/
src/modules/client/filelist.py src/modules/client/retrieve.py src/tests/api/t_imageconfig.py Copyright needs updating (year) in the above files. src/client.py ========= line 94, the usage message does not match the code at line 918 that suggests that [ -H ] is a valid option. lines 843-857, 865-872: Nitpick, but could you declare the variables and process the options in the same order that they are listed in the usage or the same order in all these places? Right now, each of them is in a different order. line 927, 941: No space after '#'. src/man/pkg.1.txt ============= lines 22-23, 54-55, (as a whole) don't match the usage message on line 89 of src/client.py. line 287, should there be a ':' after the word 'at' ? src/modules/client/image.py ==================== line 262: sometimes we seem to have "argument=None" (no spaces around equals character see client.py) and other times we have "argument = None". Which is the right one? line 302: is 'e' being used here? src/tests/cli/t_commandline.py ====================== I don't see any usage of the -k or -c command-line options here. It's also missing a test for the -H option to list authorities without the headers. Cheers, -- Shawn Walker "To err is human -- and to blame it on a computer is even more so." - Robert Orben _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
