> src/modules/client/filelist.py > src/modules/client/retrieve.py > src/tests/api/t_imageconfig.py > > Copyright needs updating (year) in the above files.
Ok, thanks. > src/client.py > ========= > > line 94, the usage message does not match the code at line 918 that > suggests that [ -H ] is a valid option. Fixed. > lines 843-857, 865-872: > > Nitpick, but could you declare the variables and process the options > in the same order that they are listed in the usage or the same order > in all these places? > > Right now, each of them is in a different order. I've made this change, but the options in set-authority and image-create don't match up exactly. I've tweaked the order and re-arranged a bit. > line 927, 941: > > No space after '#'. Thanks. > src/man/pkg.1.txt > ============= > lines 22-23, 54-55, (as a whole) don't match the usage message on > line 89 of src/client.py. > > line 287, should there be a ':' after the word 'at' ? > src/modules/client/image.py > ==================== > line 262: sometimes we seem to have "argument=None" (no spaces around > equals character see client.py) and other times we have "argument = > None". Which is the right one? Spaces. I've inserted some where I could find them missing. > line 302: is 'e' being used here? Not so far as I can tell. Deleted. > src/tests/cli/t_commandline.py > ====================== > I don't see any usage of the -k or -c command-line options here. > > It's also missing a test for the -H option to list authorities without > the headers. I'm going to push a new webrev in just a minute. It should have a lot more tests in t_commandline. Thanks for the review. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
