Both comments addressed.
How are you running pylint?
I was using the "python setup.py lint" command, and it sets the maximum
line length to 90 in the tests/pylintrc file. It also didn't generate
the indent error (not sure why).
Thanks.
Tom
Shawn Walker wrote:
2008/6/16 Tom Mueller (pkg-discuss) <[EMAIL PROTECTED]>:
Shawn,
Thanks. I applied fixes for all of your suggestions. A new webrev is here:
http://cr.opensolaris.org/~tmueller/ips-setup2/
The only remaining pylint output for setup.py are messages regarding the two
many public methods and for defining an attribute outside of __init__. I
don't think anything can be done about these as they are result of extending
the distutils classes.
Yes, I tend to ignore most of the warnings pylint gives (especially
the regex pattern for variables).
I have two final comments.
Is there a reason that you don't use os.path.join for cases such as these:
http://cr.opensolaris.org/~tmueller/ips-setup2/src/setup.py.wdiff.html
212 + proto = "%s/%s" % (root_dir, py_install_dir)
305 + '--install-lib=%s/%s' % (root_dir,
py_install_dir),
306 + '--install-data=%s/%s' % (root_dir,
py_install_dir)],
?
Finally, this:
289 + if not os.path.exists(CPARC) or
hdr.gettype() != "application/x-gzip":
290 + print "Unable to retrieve
%s.\nPlease retrieve the file and place it at: %s\n" % (CPURL, CPARC)
Needs to be split up and changed a tiny bit:
if not os.path.exists(CPARC) or \
hdr.gettype() != "application/x-gzip":
print "Unable to retrieve %s.\nPlease retrieve
the file " \
"and place it in the src directory." % (CPURL)
These pylint warnings are also still showing:
C: 63: Line too long (82/80)
C: 64: Line too long (84/80)
C: 65: Line too long (82/80)
C:197: Line too long (88/80)
C:215: Line too long (85/80)
C:225: Line too long (83/80)
C:227: Line too long (82/80)
C:239: Line too long (84/80)
C:259: Line too long (81/80)
C:270: Line too long (85/80)
C:273: Line too long (81/80)
C:289: Line too long (86/80)
C:290: Line too long (119/80)
C:321: Line too long (82/80)
C:328: Line too long (88/80)
C:333: Line too long (84/80)
C:338: Line too long (84/80)
C:341: Line too long (81/80)
C:378: Line too long (83/80)
C:382: Line too long (88/80)
C:385: Line too long (92/80)
W:385: Bad indentation. Found 20 spaces, expected 24
C:387: Line too long (85/80)
W:387: Bad indentation. Found 20 spaces, expected 24
W:431: Bad indentation. Found 4 spaces, expected 8
W:432: Bad indentation. Found 4 spaces, expected 8
W:445: Bad indentation. Found 4 spaces, expected 8
W:446: Bad indentation. Found 8 spaces, expected 16
W:447: Bad indentation. Found 8 spaces, expected 16
W:457: Bad indentation. Found 4 spaces, expected 8
W:458: Bad indentation. Found 8 spaces, expected 16
Cheers,
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
