Hi Danek, Just a couple of nits: catalog.py 647-653 Please update this comment
image.py 132-133 Could you elaborate on the difference between "required_subdirs" and "image_subdirs"? (and if it's what I believe it is, can you place "index" into the image_subdirs instead of the required subdirs?) Thanks, Brock Danek Duvall wrote: > On Wed, Jul 09, 2008 at 05:02:43PM -0700, Danek Duvall wrote: > > >> It's a tad slower than I'd like, but I'm not sure where else to shave. >> > > Stephen asked what the overhead of just loading python and all the modules > was, and we figured that "pkg version" was about as a do-nothing command as > we have, and that takes approx .15s of the .67 minimum time. The pickle > load alone takes .42s, so that leaves .1s for running through the loop, > which isn't half bad. > > I'd bet that object instantiation, rather than parsing, is the majority of > the time taken in loading the pickle file, but I suppose we'll see with > Dan's wad. :) > > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
