2008/7/10 Danek Duvall <[EMAIL PROTECTED]>: > On Thu, Jul 10, 2008 at 04:19:23PM -0500, Shawn Walker wrote: > >> http://cr.opensolaris.org/~dduvall/pkg-newlist2/src/modules/client/image.py.html >> ========== >> 857 os.path.join(thedir, v, >> d, "installed")) >> >> Use constant here. > > That's not the state text, that's the name of a file. :)
Arg. My bad -- nevermind. >> Only other comment > > ... is? I hate my keyboard :-) My numlock key was stuck on for some reason and I was having to use the function key to type vowels, hence the premature send. Actually, the question was whether the constants would be better off in misc.py so they can be reused other places easily enough or whether you thought they belonged in image.py. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
