Another webrev for search is up, based on suggestions from Dan, the memory requirements have been curtailed quite a bit. Before indexing, the process seems to top out at around 116M. The indexing then takes that to 133M (instead of the 198M it used to require).
The revised webrev is here: http://cr.opensolaris.org/~bpytlik/ips-search/ Thanks, Brock Brock Pytlik wrote: > Danek Duvall wrote: > >> On Tue, Jul 08, 2008 at 05:59:11PM -0700, Brock Pytlik wrote: >> >> >> >>> Thanks for getting back to me so fast. >>> >>> The updated webrev is at: >>> >>> http://cr.opensolaris.org/~bpytlik/ips-search/ >>> >>> >> Could you regenerate the webrev after removing tab indentations? There are >> a handful of places where it looks like that's the only thing that's >> changed, but it's difficult to be absolutely sure. While you're at it, you >> should eliminate all trailing whitespace, too, of which you seem to have >> introduced quite a bit. >> >> Thanks, >> Danek >> >> > Sorry about that. I was looking at SDIFFs, which don't seem to show > those differences. > I've also pulled all trailing white space out of all of the files. > > Based on some other feedback, I've changed the catalog temp file to use > tempfile.mkstmp instead of the previous method. > > Revised webrev is up at > > http://cr.opensolaris.org/~bpytlik/ips-search/ > > > Brock > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
