Danek Duvall wrote: > On Sun, Jul 13, 2008 at 09:20:11PM -0700, Brock Pytlik wrote: > > >> The revised webrev is here: >> >> http://cr.opensolaris.org/~bpytlik/ips-search/ >> > > Always publish updated webrevs (unless extremely minor, or don't change > line numbers) to a new url so that people who are in the middle of a review > of the original webrev (like me) don't suddenly have an invalid review. > > If you still have the old webrev, please repost it, move this to a new URL, > and post the incremental. Though perhaps the changes are really very > minor? > > Thanks, > Danek > Sorry, didn't know that. I don't have a copy of the old webrev. The changes are as follows: In imageplan, I delete a bunch of state before making the call to the indexer and no longer pack the filter file path for the original fmri in the pkg plan into the list which is passed to the indexer. Because the indexer no longer needs the filter files (see below) the actions are postexecute'd prior to the indexer being called.
In indexer, I no longer use the filter file on manifest for the original fmri. If needed, I can explain in detail why it's not necessary, but I doubt it will matter much. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
