Hi Shawn,
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-2239/
As far as the new code is concerned, there are a few methods in
repositoryconfig.py that need to be changed to properly handle boolean
values.
It looks like the code in read() is okay; however, _set_attribute() and
is_valid_attribute_value() don't properly check booleans. Take a look
at this example from my Python interpreter:
$ python
Python 2.4.4 (#1, Feb 12 2008, 12:50:35) [C] on sunos5
Type "help", "copyright", "credits" or "license" for more information.
>>> b = bool("False")
>>> print b
True
>>> c = bool("Potato!")
>>> print c
True
Notice that in both cases passing any non-empty string to bool() will
create a True boolean object. I don't really think this is what you
intended, so this may need a bit of adjustment.
When it comes to running multiple repositories on the same machine, it's
generally preferable to run each repository under a different PID. This
allows us to use OS-level resource-management features on the box, if
desired. I know at some point in the past, you had talked about running
multiple repositories through the same depot server. I don't know if
your config stuff is set up to handle this now, but it's probably not
something that we'll want to do often. It's preferable to have a 1:1:1
relationship between repository, depot, and process.
-j
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
