On Wed, Aug 13, 2008 at 07:58:28PM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-2333-2888/
Have to say I'm not that thrilled with 2888. I think it can be useful to
have multiple instances of an option, latest taking effect, so that scripts
and aliases can put in defaults which can be overridden on the commandline.
I doubt I'll care too much here, but I'm not sure I want to see this trend
continue.
depot.py:
- line 164: you went to the trouble of creating log_opts above, but don't
use it here. Oversight?
- line 314: I don't understand this. Line 316 should set the destination
of a particular log to the empty string if it's stdout, stderr, or
none? I think you might want to comment that.
- line 380: While you're there, shouldn't this be using emsg?
I wonder also if it'd be worthwhile to restore the original behavior if
stdout is a tty?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
