Danek Duvall wrote: > On Wed, Aug 13, 2008 at 07:58:28PM -0500, Shawn Walker wrote: > >> http://cr.opensolaris.org/~swalker/pkg-2333-2888/ > > Have to say I'm not that thrilled with 2888. I think it can be useful to > have multiple instances of an option, latest taking effect, so that scripts > and aliases can put in defaults which can be overridden on the commandline. > > I doubt I'll care too much here, but I'm not sure I want to see this trend > continue.
Multiple instances of an option are usually intended to provide multiple, unique value to a program -- not to override previously specified ones. If we ever did have an option that could be specified more than once, would that not confuse matters? Nevertheless, my heart isn't set on the change, so I've removed it and I've invalidated 2888. > depot.py: > > - line 164: you went to the trouble of creating log_opts above, but don't > use it here. Oversight? Somewhat. I probably didn't think of it because of the '=' that has to be appended to each one. Changed. > - line 314: I don't understand this. Line 316 should set the destination > of a particular log to the empty string if it's stdout, stderr, or > none? I think you might want to comment that. It's setting cherrypy's destination which is different than ours. Because I am replacing cherrypy's default log handlers with my own, I don't want any of the output sent to a file. Comment added. > - line 380: While you're there, shouldn't this be using emsg? I've changed all the print statements to use the appropriate method. > I wonder also if it'd be worthwhile to restore the original behavior if > stdout is a tty? Sure. New webrev: http://cr.opensolaris.org/~swalker/pkg-2333-2/ -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
