On Fri, Aug 15, 2008 at 10:00:19PM -0700, Brad Hall wrote: > OK, got rid of those lines; I'll punt on this case for now since the common > case is to run the test suite via make test or setup.py. Webrev updated > inplace.
I didn't see the original, so I'm not sure what changed, but does this mean that running the tests from run.py on the commandline no longer works? Should the special casing around importing t_elf go away, now that you trap import errors on all imports? line 91: do you ever see objects of type ClassType? A check of a couple modules showed they were just type "type", but I wasn't too thorough. line 98: no need for the parens. Looks nice. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
