On Fri, Aug 15, 2008 at 11:32:35PM -0700, Danek Duvall wrote: > On Fri, Aug 15, 2008 at 10:00:19PM -0700, Brad Hall wrote: > > > OK, got rid of those lines; I'll punt on this case for now since the common > > case is to run the test suite via make test or setup.py. Webrev updated > > inplace. > > I didn't see the original, so I'm not sure what changed, but does this mean > that running the tests from run.py on the commandline no longer works? > > Should the special casing around importing t_elf go away, now that you trap > import errors on all imports? > > line 91: do you ever see objects of type ClassType? A check of a couple > modules showed they were just type "type", but I wasn't too thorough. > > line 98: no need for the parens. > > Looks nice. > > Danek
Running from run.py will work if you're in the tests directory, but not from the src directory, at the moment. I'm still trying to figure out a way to do that cleanly (both make test and setup.py just cd to the tests dir). I suppose we could have run.py figure out that you're in the src dir and chdir itself or something. Re: t_elf; you're right -- removed. 91: I'll go through and check all of them, if there isn't any ClassType objects I'll remove that part of the check. 98: removed Thanks, Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
