Could I impose upon you to beef up the test case to include some more bad packages? It would be great if you'd include some that contain other characters that are forbidden by your regex.
Thanks! -j On Wed, Aug 20, 2008 at 05:21:27PM -0500, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 1730 package containing space in name handled incorrectly > > Webrev: > http://cr.opensolaris.org/~swalker/pkg-1730/ > > Change Summary: > * Add a new misc.is_valid_pkg_name method using a regex from > doc/tags-and-attributes.txt > * Changes modules/catalog.py to check this in valid_new_fmri(). > * Adds a new test to cli/t_actions.py to ensure that bad package > names are rejected by the server during "open". > * Updates baseline.txt to include new tests. > * Changes cli/testutils.py:pkgsend_bulk to support having an expected > exit status. > * Fixes a case in t_actions.py where if a depot server couldn't be > started, it would fail with a traceback instead of the normal test failure. > > Thanks, > -- > Shawn Walker > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
