Hi Shawn looks good in general. To be clear (since it's been a while since I've dug in regexps) pkg names are now allowed to have letters, . - and _ in them, and must start with a letter? This does go against what I've understood is allowed to be in a package name, specifically, it outlaws "/" (see the discussion here: http://defect.opensolaris.org/bz/show_bug.cgi?id=2938). Do we have the list of legal characters for a fmri documented? (Either here or in other projects like SMF which also use fmris?)
Thanks, Brock Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 1730 package containing space in name handled incorrectly > > Webrev: > http://cr.opensolaris.org/~swalker/pkg-1730/ > > Change Summary: > * Add a new misc.is_valid_pkg_name method using a regex from > doc/tags-and-attributes.txt > * Changes modules/catalog.py to check this in valid_new_fmri(). > * Adds a new test to cli/t_actions.py to ensure that bad package > names are rejected by the server during "open". > * Updates baseline.txt to include new tests. > * Changes cli/testutils.py:pkgsend_bulk to support having an expected > exit status. > * Fixes a case in t_actions.py where if a depot server couldn't be > started, it would fail with a traceback instead of the normal test failure. > > Thanks, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
