On Tue 09 Sep 2008 at 07:00PM, Shawn Walker wrote:
> Danek Duvall wrote:
> > Here's a patch to add "DirectoryBundle" support:
> > 
> >     http://cr.opensolaris.org/~dduvall/pkg-dirbundle/
> > 
> > With this, you'll be able to do
> > 
> >     pkgsend import /path/to/random/directory
> > 
> > and have it spit out a set of actions corresponding to the files and
> > directories in that directory.  I don't know if there were any expectations
> > around this that aren't being met; if so, please let me know.
> 
> DirectoryBundle.py:
>    line 1: #!/usr/bin/python2.4 instead
> 
>    line 30: unused import, sys
> 
> Otherwise, looks fine.

So I'm a little lost but:

        - Is it always doing timestamps for all files?
        - I'm a little confused about "spit out a set of actions" --
          will it just emit those, or will it publish those things
          to the server along the way?
        - All files are owned by root and group bin?

A comment at the class level would be nice.   Test cases would be nice.

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to