On Tue, Sep 09, 2008 at 05:08:05PM -0700, Dan Price wrote: > So I'm a little lost but: > > - Is it always doing timestamps for all files?
That's how bart set up the timestamp stuff -- timestamps get added for all actions, and then pkgsend removes them if they're not necessary. It's ugly, but I wasn't going to redesign it for him at the time. There may have even been a reason that it was done this way, rather than changing the bundle api. At any rate, I'm leaving it this way for now. > - I'm a little confused about "spit out a set of actions" -- > will it just emit those, or will it publish those things > to the server along the way? It'll emit those. Just like the other bundles. What you do with those actions is entirely up to you. Right now, pkgsend can only publish them. I've got another patch in the works that will print them to a file. > - All files are owned by root and group bin? Would dp:other be preferable? I'm assuming that in most cases, the user and group as they are on the filesystem are not as you want them published, because they're probably you. TarBundle uses the bundled user data, but that seems like it is a bit more trustable. In general, we want some way of overriding attributes like this either for individual actions, or for the entire bundle. I'm not sure what that interface looks like yet, and the easy answer is to use a bundle type with richer metadata. Or emit the actions to a file and edit it before publication, which is probably the way we'll end up doing it in ON. > A comment at the class level would be nice. Sure. > Test cases would be nice. I agree this is a good idea. We have no test cases for any of the bundle types, and so no good framework to copy for this one. Do you want to file the bug, or should I? Or do we care that this might not make build 98? Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
