Dan, Thanks for looking this over.
Dan Price wrote: > On Tue 16 Sep 2008 at 01:01PM, Jerry Jelinek wrote: >> I need a code review for the initial zones/SNAP upgrade >> integration. The webrev is at: >> >> http://cr.opensolaris.org/~gjelinek/zones_snap/ >> >> For reference, the spec is at: >> >> http://www.opensolaris.org/jive/thread.jspa?threadID=70461&tstart=0 > > Jerry-- overall, looks good. > > brand/common -- maybe give this file a suffix (.ksh or something) so that > we know what language it is supposed to be? It also looks like it's > executable, which seems somehow wrong. I'll change that. > In the past we've "supported" (== occasionally tested) this brand on > nevada systems. Is that doomed at this point? It won't work as things stand today, since there is no beadm support on nevada. I'm sure I could make it work with or without beadm if you think thats important. Let me know. > What will happen for customers who have older zones? Must they > uninstall to keep working? Or could they detach and then attach? > If yes, what will the failure mode look like if they do not? Yes, zones created prior to this change will not work. I need to do more work on detach/attach for this brand. I am working on the base zones changes that allow me to mount branded zones. I think we could make attach work, but it is not there in this webrev. Would you like me to do more work on that? I could probably make the attach part work without have the mount support yet. Mount is needed to update the zone when we attach. The error the user will see will either be: Error: unable to determine global zone boot environment. or Error: no active dataset. The first happens with the current beadm code since it does not yet have a UUID on the BE in b98. Going from b98 to b99 will get you a UUID. I've talked to them about back publishing their changes to you can get UUIDs earlier than the b98 to b99 transition. The second error happens if you do have a UUID on the gz BE, since the zone has not been installed using the new design. > Can you tell me more about the egrep invocations > (like in uninstall:81,146,163)? I'm wondering why we can't just > list what we need specifically? I was thinking that we could > invoke > > zfs list -H -r -t filesystem -o name,$PROP_PARENT,$PROP_ACTIVE > "$ZONEPATH_DS/ROOT" I can change the implementation to do it that way. The parsing will have to be done differently, so I'll work on that and post a new webrev when it is ready. > I'm now running 98. Do I need corresponding changes in libbe or > anything to try this out? Can I just apply your patch to my > workspace? Unfortunately boot environments on b98 don't have a UUID, so it won't work. As it stands now, you have to image-update from b98 to b99 (or later) to get a UUID on your latest BE. If they backpublish the beadm changes, the window will be wider, but I think they said they could only backpublish to b96 since they have some other dependencies. Thanks, Jerry _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
