Dan Price wrote: > On Tue 16 Sep 2008 at 01:01PM, Jerry Jelinek wrote: >> I need a code review for the initial zones/SNAP upgrade >> integration. The webrev is at: >> >> http://cr.opensolaris.org/~gjelinek/zones_snap/ >> >> For reference, the spec is at: >> >> http://www.opensolaris.org/jive/thread.jspa?threadID=70461&tstart=0 > > Jerry-- overall, looks good. > > brand/common -- maybe give this file a suffix (.ksh or something) so that > we know what language it is supposed to be? It also looks like it's > executable, which seems somehow wrong. > > In the past we've "supported" (== occasionally tested) this brand on > nevada systems. Is that doomed at this point? > > What will happen for customers who have older zones? Must they > uninstall to keep working? Or could they detach and then attach? > If yes, what will the failure mode look like if they do not? > > Can you tell me more about the egrep invocations > (like in uninstall:81,146,163)? I'm wondering why we can't just > list what we need specifically? I was thinking that we could > invoke > > zfs list -H -r -t filesystem -o name,$PROP_PARENT,$PROP_ACTIVE > "$ZONEPATH_DS/ROOT" > > I'm now running 98. Do I need corresponding changes in libbe or > anything to try this out? Can I just apply your patch to my > workspace?
Dan, I addressed your feedback and I have posted a new webrev at: http://cr.opensolaris.org/~gjelinek/zones_snap1/ I also fixed the code so you can still use this brand on nv. Let me know if you have any other comments. Thanks, Jerry _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
