Brad Hall wrote: > On Mon, Oct 06, 2008 at 04:51:25PM -0700, Dan Price wrote: > >> On Thu 04 Sep 2008 at 06:47PM, Shawn Walker wrote: >> >>>> Here's a new fix for this since realizing the brokenness that I had >>>> introduced >>>> was a little further down than we originally thought. >>>> >>>> New webrev: http://cr.opensolaris.org/~bhall/bug-2323/ >>>> >>>> Change Summary: >>>> * Make the test suite pass the testcase as the object to addError, instead >>>> of >>>> the test suite. >>>> >>> I've verified that this resolves my issue and I don't see the other >>> problem you found anymore. >>> >> I'm slightly confused. Is this bug still open? I see 3232 in the >> bug db as open. >> >> If it is awaiting review I can help review, but it seems like you >> two guys agreed on a solution and the code is ready to go? >> >> -dp >> >> -- >> Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - >> blogs.sun.com/dp >> > > So this was fixed in Brock's putback #516.. looks like we forgot to add this > bug # to his list. > Oops, that's right, I had to make that change to get my tests working. I think I had expected the changes to come in before my put back went in, but they didn't and I had forgotten about them. Sorry about that.
Brock > -Brad > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
