Bart,
A couple of questions/comments.
The imageplan module creates an OpenSolaris-specific and full image (or
root user) specific Actuator object without any check regarding the
environment where this is running. I noticed that there is a comment in
actuator about there needing to be an OS-specific module defined.
What is the plan for actually creating the OS-specific or image
type-specific GenericAcuator instance?
Would you expect that the classes for other types of actuators would be
in the actuator.py file?
Would there be a factory method in actuator.py that creates the right
one and then imageplan would call that?
Also, what is the plan for user images and non-root users?
Would there be a user-image specific actuator? Or maybe a non-root user
actuator?
Would installing a package that has actuator attributes that are ignored
be considered an error? Or are they just silently ignored?
It would seem that if a package containing one of these action
attributes was installed into a user image by a non-root user, the
client would go ahead and try to run /usr/bin/svcadm and fail. Maybe
the plan is that people just shouldn't do that.
If you could please create an issue that describes your thoughts on
these porting aspects, I'd be glad to take on that project after 2008.11
is done.
Thanks.
Tom
Bart Smaalders wrote:
Bart Smaalders wrote:
Thanks for looking at this. I'll retest, resync and retest and
respin the webrev. I'll likely push tomorrow ...
Changeset has been resynced, merged and passes tests once again:
http://cr.opensolaris.org/~barts/triggers/
- Bart
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
