This looks okay to me. Just to make sure I understand, 3704 just covers the fact that we have no top level handler for the InventoryException, correct? I didn't see anything that addressed optional dependency lookup, but I thought I'd ask just to be sure.
-j On Tue, Oct 14, 2008 at 06:57:10PM -0500, Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 3704 InventoryException raised if optional dependencies not in catalog > 3890 ImageNotFoundException created with wrong number of arguments > > webrev: > http://cr.opensolaris.org/~swalker/pkg-3704-3890 > > This fix will ensure that the client exits with "1" (handled error) > instead of "99" (unknown exception) or something else. > > Known Caveats > ============= > * I didn't know how to write a test to ensure that the find_root > ImageNotFoundException will get raised for bug 3704 or 3890 since as > long as you're running the test on an OpenSolaris 2008 system, it will > error at a different spot. It will only reliably fail on a system that > does not have /var/pkg. > > Change Summary > ============== > * Re-added __str__ handler to InventoryException (regression of bug 3483). > > * Changed client to expect a possible InventoryException for > image-update and uninstall cases. > > * Fixed exception error encountered during raising an exception if > find_root fails in a particular case. > > * Added test to verify that attempting to install a package or use > image-update on a package with an optional dependency that is not > available in the current catalog(s) fails. > > Cheers, > -- > Shawn Walker > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
