jmr wrote: > Looks good, like the change to the error handling to just put out the > exception details in the Details pane of the dialog, a lot more future > proof as commented on a number of bugs on the list already. > > I understand we need to handle the incorporation error when doing an > install, but it would be much better if we could get the incorporated > state back filled out correctly in the package state returned from the > inventory. (image.py: __inventory() state "incorporated": line 1816). > Then we could mark the packages as incorporated and if a user selects > them only Update All would be enabled. I see the code there to put in > the state info, but its only doing it for version. > > See you have added MAX_DESCRIPTION, would be fantastic to get this back > in the catalog as opposed to having to dig into the manifests and the > size cost particularly when compressed would be relatively small > (catalog opensolaris.org 850k, compressed 110k: adding descriptions > limited to 60 chars would double this figure, still a minor hit on pkg > refresh). > > A few minor comments:
Hi John, New webrev: http://cr.opensolaris.org/~migi/20_10_2008_bugfixing_v2/ > Use more informative names for widgets in glade > > src/gui/modules/installupdate.py > 98 + remove_warning_triange = \ > 99 + w_tree_installupdate.get_widget("image4") Renamed variable to warningtriangle, as this is the yellow warning triangle for the remove action. > Assume: > > def __do_ips_uptodate_check(self): > > Change is to handle cancel in Update if there is a network failure? > > > Pylint: > ~/work/ips_gate$ pylint > --rcfile=/export/home/jr140578/work/ips_gate/src/tests/gui_pylintrc > /tmp/packagemanager.py > ************* Module packagemanager > R:459:PackageManager.__status_sort_func: Method could be a function Fixed > W:1256:PackageManager.__ipkg_ipkgui_uptodate: Unused variable 'cre' Will no fix, we need to get this value from the function, but we are doing nothing with that value. > ~/work/ips_gate$ pylint > --rcfile=/export/home/jr140578/work/ips_gate/src/tests/gui_pylintrc > /tmp/installupdate.py > ************* Module installupdate > C:329: Line too long (92/90) Fixed. > W:288:InstallUpdate.__plan_the_install_updateimage_ex: No exception > type(s) specified Will not fix. This is for purpose. We are caching all other exceptions then we know about and print nice dialog with not known error. > R:299:InstallUpdate.__plan_the_install_updateimage: Too many return > statements (15/10) Will not fix, as we are catching all the exceptions for three actions and printing nice dialog and then returning true/false depending what exception was raised. > W:382:InstallUpdate.__plan_the_install_updateimage: Unused variable > 'opensolaris_image' Will not fix. we need to get this value from the func. > W:451:InstallUpdate.__prepare_stage_ex: No exception type(s) specified > W:491:InstallUpdate.__execute_stage_ex: No exception type(s) specified Will not fix. This is for purpose. We are caching all other exceptions then we know about and print nice dialog with not known error. > W:766:InstallUpdate.get_datetime: Used * or ** magic best Michal > > Michal Pryc wrote: >> Hi, >> Bugs which will be closed with the webrev: >> >> http://cr.opensolaris.org/~migi/20_10_2008_bugfixing_v1/ >> >> Bugs addresed: >> 3911 menu item, dialog header 'Manage Repositories' >> >> 1798 UI improvements: >> resizable columns, >> >> 1568 Minor IPS GUI annoyances (RC2): >> - Not being able to resize or sort columns >> - sorting on the status >> >> 3462 packagermanager is huge when package description is huge >> >> 3493 Text on the buttons are missing on vermillion 99 >> >> 2780 Firefox Fails To Start After Package Upgrade >> >> 3967 Misleading error message for PlanCreationException >> >> 2968 GUI should handle update failure due to incorporation >> > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
