jmr wrote: > Michal - few minor nits. Fine, Changed unknown exceptions to Exception.
I'll push those to the gate then. best Michal > > JR > >>> W:288:InstallUpdate.__plan_the_install_updateimage_ex: No exception >>> type(s) specified >> Will not fix. This is for purpose. We are caching all other exceptions >> then we know about and print nice dialog with not known error. > Should catch this as Exception, I know all the low level exceptions are > being caught, but good to have the catch all and document it as such. >>> R:299:InstallUpdate.__plan_the_install_updateimage: Too many return >>> statements (15/10) >> Will not fix, as we are catching all the exceptions for three actions >> and printing nice dialog and then returning true/false depending what >> exception was raised. >>> W:382:InstallUpdate.__plan_the_install_updateimage: Unused variable >>> 'opensolaris_image' >> Will not fix. we need to get this value from the func. >> >>> W:451:InstallUpdate.__prepare_stage_ex: No exception type(s) specified >>> W:491:InstallUpdate.__execute_stage_ex: No exception type(s) specified >> Will not fix. This is for purpose. We are caching all other exceptions >> then we know about and print nice dialog with not known error. >> > Should catch this as Exception, I know all the low level exceptions are > being caught, but good to have the catch all and document it as such. >>> W:766:InstallUpdate.get_datetime: Used * or ** magic >> >> best >> Michal >> >>> Michal Pryc wrote: >>>> Hi, >>>> Bugs which will be closed with the webrev: >>>> >>>> http://cr.opensolaris.org/~migi/20_10_2008_bugfixing_v1/ >>>> >>>> Bugs addresed: >>>> 3911 menu item, dialog header 'Manage Repositories' >>>> >>>> 1798 UI improvements: >>>> resizable columns, >>>> >>>> 1568 Minor IPS GUI annoyances (RC2): >>>> - Not being able to resize or sort columns >>>> - sorting on the status >>>> >>>> 3462 packagermanager is huge when package description is huge >>>> >>>> 3493 Text on the buttons are missing on vermillion 99 >>>> >>>> 2780 Firefox Fails To Start After Package Upgrade >>>> >>>> 3967 Misleading error message for PlanCreationException >>>> >>>> 2968 GUI should handle update failure due to incorporation >>>> >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
